lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF
Date
On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
>
> config SND_SOC_LPASS_CPU
> tristate
> + depends on OF
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_PLATFORM
> tristate
> + depends on OF
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_IPQ806X
>

Could you instead make the drivers compile without OF being set?

I see that patch 7 and 8 introduces another two options doing


+config SND_SOC_LPASS_APQ8016
+ tristate
+ depends on SND_SOC_QCOM
+ select SND_SOC_LPASS_CPU
+ select SND_SOC_LPASS_PLATFORM
+

+config SND_SOC_APQ8016_SBC
+ tristate "SoC Audio support for APQ8016 SBC platforms"
+ depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
+ select SND_SOC_LPASS_APQ8016
+ help

so you get an obvious build failure here when SND_SOC_APQ8016_SBC
gets selected with COMPILE_TEST on a platform that does not support OF.

Arnd


\
 
 \ /
  Last update: 2015-05-22 09:41    [W:0.158 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site