lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF
Date
On Friday 22 May 2015 09:24:35 Arnd Bergmann wrote:
> Could you instead make the drivers compile without OF being set?
>
> I see that patch 7 and 8 introduces another two options doing
>
>
> +config SND_SOC_LPASS_APQ8016
> + tristate
> + depends on SND_SOC_QCOM
> + select SND_SOC_LPASS_CPU
> + select SND_SOC_LPASS_PLATFORM
> +
>
> +config SND_SOC_APQ8016_SBC
> + tristate "SoC Audio support for APQ8016 SBC platforms"
> + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
> + select SND_SOC_LPASS_APQ8016
> + help
>
> so you get an obvious build failure here when SND_SOC_APQ8016_SBC
> gets selected with COMPILE_TEST on a platform that does not support OF.
>
>

Actually, the patch 9bae4880acee ("ASoC: qcom: move ipq806x specific
bits out of lpass driver.") already broke things more after I fixed it
up. Please fold in this bit too before you send it again, and
try to test the changes you send:

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index b30c2baa7501..08ebc9b8f915 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -20,7 +20,7 @@ config SND_SOC_LPASS_IPQ806X

config SND_SOC_STORM
tristate "ASoC I2S support for Storm boards"
- depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
+ depends on SND_SOC_QCOM && (ARCH_QCOM || COMPILE_TEST)
select SND_SOC_LPASS_IPQ806X
select SND_SOC_MAX98357A
help



Arnd


\
 
 \ /
  Last update: 2015-05-22 15:41    [W:0.473 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site