lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 04/33] staging: rtl8192e: Fix DEEP_INDENTATION warning in rtllib_parse_info_param()
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
> + if (info_element->len >= 4 &&
> + info_element->data[0] == 0x00 && info_element->data[1] == 0x50 &&
> + info_element->data[2] == 0xf2 && info_element->data[3] == 0x01) {


This if statement was actually easier to read in the original code:

if (info_element->len >= 4 &&
info_element->data[0] == 0x00 &&
info_element->data[1] == 0x50 &&
info_element->data[2] == 0xf2 &&
info_element->data[3] == 0x01) {

Your eye can immediately spot the bits which are different on each line
when they are lined up like that.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-05-11 16:01    [W:0.285 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site