Messages in this thread | | | Date | Tue, 12 May 2015 22:08:01 +0200 | From | Mateusz Kulikowski <> | Subject | Re: [PATCH v3 28/33] staging: rtl8192e: Replace ?: with max |
| |
On 11.05.2015 15:22, Dan Carpenter wrote: > On Sat, May 09, 2015 at 11:19:16PM +0200, Mateusz Kulikowski wrote: (...) >> len = crypt->ops->get_key(keybuf, SCM_KEY_LEN, NULL, crypt->priv); >> - erq->length = (len >= 0 ? len : 0); >> + if (len > U16_MAX) >> + netdev_err(ieee->dev, "Too long key returned.\n"); > > Just delete the check if it can't happen or handle the error properly. > Never printed messages can be annoying. Static checkers assume all > conditions can happen so never true conditions are confusing. It wastes > RAM.
Ok, will do, thanks.
Regards, Mateusz
| |