Messages in this thread | | | Date | Thu, 09 Apr 2015 11:45:15 +0200 | From | Michael Wang <> | Subject | Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW |
| |
On 04/08/2015 10:10 PM, Jason Gunthorpe wrote: [snip] > >> As Sean pointed out, force_grh should be rdma_dev_is_iboe(). The cm > > I actually really prefer cap_mandatory_grh - that is what is going on > here. ie based on that name (as a reviewer) I'd expect to see the mad > layer check that the mandatory GRH is always present, or blow up.
Sounds good, will be in next version :-)
Regards, Michael Wang
> > Some of the other checks in this file revolve around pkey, I'm not > sure what rocee does there? cap_pkey_supported ? > > Jason >
| |