Messages in this thread | | | Date | Tue, 07 Apr 2015 00:49:24 +0200 | From | Bert Vermeulen <> | Subject | Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards |
| |
Hi Andy,
I will submit a new version with your comments addressed. However this one:
On 04/06/2015 12:13 PM, Andy Shevchenko wrote:
>> +static struct spi_driver rb4xx_cpld_driver = { >> + .probe = rb4xx_cpld_probe, >> + .remove = rb4xx_cpld_remove, >> + .driver = { >> + .name = "rb4xx-cpld", >> + .bus = &spi_bus_type, >> + .owner = THIS_MODULE, > > Do we really need this line? > > + }, > +}; > + > +module_spi_driver(rb4xx_cpld_driver);
Yes, apparently. It's only the module_platform_driver() macro that automatically fills in the owner field. All SPI protocol drivers do this (except one, video/backlight/hx8357.c). Having said that, I don't really get what that field is used for.
-- Bert Vermeulen bert@biot.com email/xmpp
| |