lkml.org 
[lkml]   [2015]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/7] tracing: Add 'hist' event trigger command
On Sat, 04 Apr 2015 15:09:05 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

>
> [PATCH] kallsyms: Include module.h
>
> KSYM_SYMBOL_LEN references MODULE_NAME_LEN, defined in module.h, so
> have kallsyms.h include module.h instead of expecting kallsysms users
> to do it.
>
> Also fix up existing kallsyms users that apparently include module.h
> for only that reason.
>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> include/linux/ftrace.h | 1 -
> include/linux/kallsyms.h | 1 +
> kernel/trace/trace_events_hist.c | 2 +-
> kernel/trace/trace_kprobe.c | 1 +
> kernel/trace/trace_output.c | 1 +
> kernel/trace/trace_syscalls.c | 2 +-
> 6 files changed, 5 insertions(+), 3 deletions(-)

Not sure you are proposing this as part of your patch set. I suggest
that you don't and post this separately.

Also, the removal of kallsyms.h from ftrace.h should be a totally
separate patch (along fixing anything that breaks when you remove it,
if C files were using ftrace.h to pull in kallsyms.h for them).

Then the addition of modules.h to kallsyms.h should be a separate
patch. And you should compile the kernel with both a make allmodconfig,
make allyesconfig, and then make allyesconfig but disable modules, and
see if anything breaks.

-- Steve


\
 
 \ /
  Last update: 2015-04-06 18:41    [W:1.181 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site