lkml.org 
[lkml]   [2015]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 5/7] tracing: Add 'hist' event trigger command
From
Date
On Mon, 2015-04-06 at 11:50 -0400, Steven Rostedt wrote:
> On Sat, 04 Apr 2015 17:14:56 +0200
> Paul Bolle <pebolle@tiscali.nl> wrote:
> > > --- a/kernel/trace/Makefile
> > > +++ b/kernel/trace/Makefile
> >
> > > +obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o
> >
> > To make sure I'm parsing this Makefile correctly: trace_events_hist.o
> > will never be part of a module, right?
>
> You don't need to be part of a module to need module.h. You may just
> need module info.

I understand.

But the main reason I added that remark was that recently I ran into a
few patches where I made annoying mistakes in parsing changes to
Makefiles. Doing so I wasted my own and other peoples time. So I decided
to be rather verbose when Makefiles are involved. Just so that people
can:
- mock me for not getting basic stuff right;
- stop paying attention to the rest of my remarks, because chances are I
didn't understand the patch in question correctly.

Thanks,


Paul Bolle



\
 
 \ /
  Last update: 2015-04-06 19:01    [W:1.073 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site