Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] iwl4965: Enable checking of format strings | Date | Tue, 28 Apr 2015 19:19:02 +0300 |
| |
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes:
> Since these fmt_* variables are just const char*, and not const > char[], gcc (and smatch) doesn't to type checking of the arguments to > the printf functions. Since the linker knows perfectly well to merge > identical string constants, there's no point in having three static > pointers waste memory and give an extra level of indirection. > > This removes over 100 "non-constant format argument" warnings from > smatch, accounting for about 20% of all such warnings in an > allmodconfig. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
So what's the conclusion, should I commit this patch or not?
Full discussion here:
https://patchwork.kernel.org/patch/5814811/
-- Kalle Valo
| |