Messages in this thread | | | From | "Rustad, Mark D" <> | Subject | Re: [PATCH] iwl4965: Enable checking of format strings | Date | Thu, 12 Feb 2015 00:41:39 +0000 |
| |
On Feb 11, 2015, at 2:51 PM, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> Since these fmt_* variables are just const char*, and not const > char[], gcc (and smatch) doesn't to type checking of the arguments to > the printf functions. Since the linker knows perfectly well to merge > identical string constants, there's no point in having three static > pointers waste memory and give an extra level of indirection. > > This removes over 100 "non-constant format argument" warnings from > smatch, accounting for about 20% of all such warnings in an > allmodconfig. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > drivers/net/wireless/iwlegacy/4965-debug.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/iwlegacy/4965-debug.c b/drivers/net/wireless/iwlegacy/4965-debug.c > index e0597bfdddb8..18855325cc1c 100644 > --- a/drivers/net/wireless/iwlegacy/4965-debug.c > +++ b/drivers/net/wireless/iwlegacy/4965-debug.c > @@ -28,10 +28,9 @@ > #include "common.h" > #include "4965.h" > > -static const char *fmt_value = " %-30s %10u\n"; > -static const char *fmt_table = " %-30s %10u %10u %10u %10u\n"; > -static const char *fmt_header = > - "%-32s current cumulative delta max\n";
Why not change these to: static const char fmt_value[] = " %-30s %10u\n"; static const char fmt_table[] = " %-30s %10u %10u %10u %10u\n"; static const char fmt_header[] = "%-32s current cumulative delta max\n";
I think that is better than the macros and avoids the extra pointers that I agree are useless.
-- Mark Rustad, Networking Division, Intel Corporation
[unhandled content-type:application/pgp-signature] | |