lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
Date
> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of
> Dan Williams
> Sent: Friday, April 17, 2015 8:35 PM
> To: linux-nvdimm@lists.01.org
> Subject: [Linux-nvdimm] [PATCH 00/21] ND: NFIT-Defined / NVDIMM Subsystem
>
...
> create mode 100644 drivers/block/nd/acpi.c
> create mode 100644 drivers/block/nd/blk.c
> create mode 100644 drivers/block/nd/bus.c
> create mode 100644 drivers/block/nd/core.c
...

The kernel already has lots of files with these names:
5 acpi.c
10 bus.c
66 core.c

I often use ctags like this:
vim -t core.c
but that doesn’t immediately work with common filenames - it
presents a list of all 66 files to choose from.

Also, blk.c is a name one might expect to see in the block/
directory (e.g., next to blk.h).

An nd_ prefix on all the filenames would help.



\
 
 \ /
  Last update: 2015-04-22 21:41    [W:0.413 / U:10.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site