Messages in this thread | | | Date | Wed, 22 Apr 2015 16:02:45 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 08/10] perf hists browser: Split popup menu actions - part 2 |
| |
On Wed, Apr 22, 2015 at 10:53:45PM +0900, Namhyung Kim wrote: > On Wed, Apr 22, 2015 at 10:41 PM, Jiri Olsa <jolsa@redhat.com> wrote: > > On Wed, Apr 22, 2015 at 10:32:21PM +0900, Namhyung Kim wrote: > >> On Wed, Apr 22, 2015 at 10:25 PM, Arnaldo Carvalho de Melo > >> <acme@kernel.org> wrote: > >> > Em Wed, Apr 22, 2015 at 10:03:25PM +0900, Namhyung Kim escreveu: > >> >> Hi Jiri, > >> >> > >> >> On Wed, Apr 22, 2015 at 12:54:09PM +0200, Jiri Olsa wrote: > >> >> > On Wed, Apr 22, 2015 at 04:18:19PM +0900, Namhyung Kim wrote: > >> >> > > + if (asprintf(optstr, "Run scripts for samples of thread [%s]", > >> >> > > + thread__comm_str(thread)) < 0) > >> >> > > + return 0; > >> >> > > + } else if (sym) { > >> > > >> >> > .............. && sym->namelen ;-) > >> > > >> >> Ouch! sorry for missing this again. > >> > > >> >> Arnaldo, any chance you can fix this if you're gonna merge it? > >> > > >> > I can do that, but that slows down my rate of merging, so, if you could > >> > do like Adrian Hunter did, and fix this up, stick a V2 tag to it, then > >> > send it as a reply to the patch being fixed, that would help, so that > >> > when I get to it, and sort by thread, I will see the fix and will use > >> > it instead. > >> > >> OK. Will send v2 soon! > > > > hum, I just told Arnaldo that I'm ok with not having the sym->namelen check.. > > > > let's leave it as it is now and if we see blank line > > then we go and fix it on the proper place > > Argh, I misunderstood your point, I thought you wanted to leave the > sym->namelen check here and removing it in another patch with some > more investigation. Yes, English is hard for me - I feel it more and > more these days ;-)
no worries, I believe mine is worse ;-)
> > So it's all OK in the current form, right?
yep
jirka
| |