lkml.org 
[lkml]   [2015]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHSET 00/10] perf tools: Assorted cleanup for TUI (v3)
Date
Hello,

This patches are to cleanup TUI hists browser code for later work. I
moved hist_entry_diff and hist_entry_tui under an union in order to
reduce memory footprint of hist entry. Also split out hist browser
functions to make it easier to read.

* changed in v3)
- save necessary info in hist_browser (Arnaldo)
- rename to struct popup_action (Arnaldo)
- split popup registration and callback (Arnaldo)
- move TUI-specific fields out of map_symbol

* changes in v2)
- add comment on the new union fields (Jiri)
- add missing sym->namelen check (Jiri)
- fix transient bug in zoom out on LEFT key press (Jiri)

It's available on 'perf/tui-cleanup-v3' branch in my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (10):
perf tools: Move TUI-specific fields into unnamed union
perf tools: Move init_have_children field to the unnamed union
perf hists browser: Fix possible memory leak
perf hists browser: Save hist_browser_timer pointer in hist_browser
perf hists browser: Save pstack in the hist_browser
perf hists browser: Save perf_session_env in the hist_browser
perf hists browser: Split popup menu actions
perf hists browser: Split popup menu actions - part 2
perf hists browser: Simplify zooming code a bit
perf tools: Move TUI-specific fields out of map_symbol

tools/perf/ui/browsers/hists.c | 603 +++++++++++++++++++++++++----------------
tools/perf/util/callchain.h | 4 +
tools/perf/util/hist.c | 2 +-
tools/perf/util/pstack.c | 7 +
tools/perf/util/pstack.h | 1 +
tools/perf/util/sort.h | 22 +-
tools/perf/util/symbol.h | 2 -
7 files changed, 399 insertions(+), 242 deletions(-)

--
2.3.5



\
 
 \ /
  Last update: 2015-04-22 09:41    [W:0.293 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site