Messages in this thread | | | Date | Thu, 02 Apr 2015 17:18:26 +0200 | From | Richard Weinberger <> | Subject | Re: [PATCH] mtd: Add simple read disturb test |
| |
Am 02.04.2015 um 17:02 schrieb Fabio Estevam: > On Thu, Apr 2, 2015 at 11:13 AM, Richard Weinberger <richard@nod.at> wrote: > >> + ret = mtdtest_erase_eraseblock(mtd, i); >> + if (ret) { >> + err = ret; >> + goto out; >> + } > > Why not just do like this instead? > > err = mtdtest_erase_eraseblock(mtd, i); > if (err) > goto out; > >> + >> + ret = mtdtest_write(mtd, i * mtd->erasesize, mtd->erasesize, >> + iobuf_orig); >> + if (ret) { >> + err = ret; >> + goto out; >> + } > > Same here.
The real question is why did I use ret and err at all? ;) This test is based on existing tests, thus it got copy&pasted. I'll think about merging these two variables. Thank for pointing this out.
>> + ret = mtdtest_relax(); >> + if (ret) >> + goto out; > > Here you propagate the wrong error. You test for 'ret' and propagate 'err'.
This is by design. I don't want to print an error message if the test is aborted. mtdtest_relax() checks for that.
Thanks, //richard
| |