Messages in this thread | | | Date | Thu, 2 Apr 2015 11:45:00 -0300 | Subject | Re: [PATCH] mtd: Add simple read disturb test | From | Fabio Estevam <> |
| |
On Thu, Apr 2, 2015 at 11:33 AM, Richard Weinberger <richard@nod.at> wrote:
> Why? Free()ing a NULL pointer is perfectly fine. > What did I miss? :)
If the first 'iobuf = kmalloc(mtd->erasesize, GFP_KERNEL);' fails then you jump to the out label where you call 5 kfree() and then return the error.
It would be much better just to return the error immediately in this case and add one label for each allocation error, so that it only kfree the previous successful allocations.
| |