lkml.org 
[lkml]   [2015]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer
On Fri, Mar 27, 2015 at 01:35:53PM +0200, Peter Ujfalusi wrote:
> The vd->node is removed from the lists when the transfer started so the
> vchan_get_all_descriptors() will not find it. This results memory leak.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> CC: Stephen Warren <swarren@wwwdotorg.org>
> CC: Lee Jones <lee@kernel.org>
Applied, thanks

--
~Vinod

> ---
> drivers/dma/bcm2835-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 0723096fb50a..c92d6a70ccf3 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -475,6 +475,7 @@ static int bcm2835_dma_terminate_all(struct dma_chan *chan)
> * c->desc is NULL and exit.)
> */
> if (c->desc) {
> + bcm2835_dma_desc_free(&c->desc->vd);
> c->desc = NULL;
> bcm2835_dma_abort(c->chan_base);
>
> --
> 2.3.3
>

--


\
 
 \ /
  Last update: 2015-03-30 20:21    [W:0.095 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site