Messages in this thread | | | Date | Sat, 28 Mar 2015 23:50:08 +0200 | From | Peter Ujfalusi <> | Subject | Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer |
| |
Thanks,
On 03/28/2015 05:57 AM, Stephen Warren wrote: > On 03/27/2015 05:35 AM, Peter Ujfalusi wrote: >> The vd->node is removed from the lists when the transfer started so the >> vchan_get_all_descriptors() will not find it. This results memory leak. > > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > (I'm just assuming the explanation makes sense and is correct; more of a > not-a-NAK so it doesn't look like a lack of response!)
I can not debug the bcm2835-dma driver, but the exact same pattern existed in edma and omap-dma driver and they both leaked the edesc in a same predictable fashion. I just checked the virt-dma users and sent the fixes for the ones which had the same flow of events.
-- Péter
| |