lkml.org 
[lkml]   [2015]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: gadgetfs broken since 7f7f25e8
On Tue, Mar 03, 2015 at 10:47:14AM -0500, Alan Stern wrote:
> @@ -1279,6 +1284,9 @@ ep0_poll (struct file *fd, poll_table *w
> struct dev_data *dev = fd->private_data;
> int mask = 0;
>
> + if (dev->state <= STATE_DEV_OPENED)
> + return -ENODEV;
> +
> poll_wait(fd, &dev->wait, wait);
>
> spin_lock_irq (&dev->lock);

That, BTW, is wrong. ->poll() does *not* return negatives - to imitate
"we don't have ->poll()" we need it to return DEFAULT_POLLMASK.


\
 
 \ /
  Last update: 2015-03-03 23:41    [W:1.013 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site