Messages in this thread | | | Date | Sun, 22 Mar 2015 11:19:33 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 14/31] perf build: Rename PERF-FEATURES into FEATURE-DUMP |
| |
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> From: Jiri Olsa <jolsa@kernel.org> > > Preparing for feature checks separation, moving related stuff under > 'FEATURE*' namespace. > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > Cc: David Ahern <david.ahern@oracle.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Link: http://lkml.kernel.org/n/tip-v9oo22ra70rrk1dy495a7bjc@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
So I think the various capital letter files in $(cwd) are highly suboptimal:
FEATURE-DUMP PERF-CFLAGS PERF-VERSION-FILE
I think we should standardize on something less pushy (no shouting), plus more standardized, more logical, more coherent names, i.e. something like:
.build.features.cache .build.cflags .build.version
?
.build.features.* would be reserved to the generic feature detection machinery.
.build.cflags and .build.version could be used by the perf build - hopefully exported to tools/build/ as well in the future! :-)
That way the .gitignore could just ignore .build.* and we'd not have to update it much.
Btw., another small nit: could we please do a (git-)rename of tools/build/feature/ to tools/build/features/?
Plural is what is used typically for generic frameworks that deal with a set of items (features in this case) - for example we have tools/tests/, and tools/perf/scripts/, not tools/test/ and tools/perf/script/.
Thanks,
Ingo
| |