lkml.org 
[lkml]   [2015]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/31] perf build: Rename PERF-FEATURES into FEATURE-DUMP
Em Sun, Mar 22, 2015 at 11:19:33AM +0100, Ingo Molnar escreveu:
>
> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> > From: Jiri Olsa <jolsa@kernel.org>
> >
> > Preparing for feature checks separation, moving related stuff under
> > 'FEATURE*' namespace.
> >
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > Cc: David Ahern <david.ahern@oracle.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Link: http://lkml.kernel.org/n/tip-v9oo22ra70rrk1dy495a7bjc@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> So I think the various capital letter files in $(cwd) are highly
> suboptimal:
>
> FEATURE-DUMP
> PERF-CFLAGS
> PERF-VERSION-FILE
>
> I think we should standardize on something less pushy (no shouting),
> plus more standardized, more logical, more coherent names, i.e.
> something like:
>
> .build.features.cache
> .build.cflags
> .build.version
>
> ?
>
> .build.features.* would be reserved to the generic feature detection
> machinery.
>
> .build.cflags and .build.version could be used by the perf build -
> hopefully exported to tools/build/ as well in the future! :-)
>
> That way the .gitignore could just ignore .build.* and we'd not have
> to update it much.

Agreed, Jiri?

> Btw., another small nit: could we please do a (git-)rename of
> tools/build/feature/ to tools/build/features/?

> Plural is what is used typically for generic frameworks that deal with
> a set of items (features in this case) - for example we have
> tools/tests/, and tools/perf/scripts/, not tools/test/ and
> tools/perf/script/.

This one is easy enough, will do in my next pull req.

- Arnaldo


\
 
 \ /
  Last update: 2015-03-23 15:21    [W:0.082 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site