Messages in this thread | | | Date | Thu, 19 Mar 2015 09:00:02 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] trace, RAS: remove unnecessary const |
| |
On Thu, 19 Mar 2015 19:57:17 +0800 Xie XiuQi <xiexiuqi@huawei.com> wrote:
> On 2015/3/19 18:33, Borislav Petkov wrote: > > On Thu, Mar 19, 2015 at 04:50:04PM +0800, Xie XiuQi wrote: > >> These parameters are passed by value. There's no need to make them const. > > > > I can think of a reason: > > > > include/trace/../../include/ras/ras_event.h: In function ‘ftrace_raw_event_mc_event’: > > include/trace/../../include/ras/ras_event.h:136:35: error: assignment of read-only parameter ‘top_layer’ > > __entry->top_layer = top_layer = 12; > > Oh, indeed. Thanks, Boris! >
Don't get too excited about that answer. If this is indeed the case, then all functions with parameters that do not get modify later should be set to const. Do we really want that? And how does this fix:
__entry->top_layer = 12;
-- Steve
| |