lkml.org 
[lkml]   [2015]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 20/24] perf stat: Always correctly indent ratio column

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
>
> When cycles or instructions do not print anything, as in being,
> --per-socket or --per-core modi, the ratio column was not correctly
> indented for them. This lead to some ratios not lining up with the
> others. Always indent correctly when nothing is printed.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Link: http://lkml.kernel.org/r/1426087682-22765-3-git-send-email-andi@firstfloor.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/builtin-stat.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index e78c68df2152..41b296fff307 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1093,7 +1093,8 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> if (total) {
> ratio = avg / total;
> fprintf(output, " # %5.2f insns per cycle ", ratio);
> - }
> + } else
> + fprintf(output, " ");

The standard pattern is symmetric curly braces.

> @@ -1162,7 +1163,8 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
> if (total) {
> ratio = avg / total;
> fprintf(output, " # %8.3f GHz ", ratio);
> - }
> + } else
> + fprintf(output, " ");

Ditto...

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-03-13 08:41    [W:0.056 / U:3.972 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site