lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers
Hello.

On 3/12/2015 6:13 AM, Scott Wood wrote:

> Use %pS for actual addresses, otherwise you'll get bad output

%pS or %ps?

> on arches like ppc64 where %pF expects a function descriptor.

%pF or %pf? And what is a function descriptor?

> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: linux-usb@vger.kernel.org
> Cc: Felipe Balbi <balbi@ti.com>
[...]

> diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> index 491082a..89179ab 100644
> --- a/drivers/usb/gadget/function/u_serial.c
> +++ b/drivers/usb/gadget/function/u_serial.c
> @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
> unsigned long flags;
> int status;
>
> - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
> port->port_num, tty, ch, __builtin_return_address(0));
[...]

WBR, Sergei



\
 
 \ /
  Last update: 2015-03-12 14:01    [W:1.672 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site