lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers
From
Date
On Wed, 2015-03-11 at 23:45 -0500, Felipe Balbi wrote:
> On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor.
> >
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> > Cc: linux-usb@vger.kernel.org
> > Cc: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/usb/gadget/function/u_serial.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c
> > index 491082a..89179ab 100644
> > --- a/drivers/usb/gadget/function/u_serial.c
> > +++ b/drivers/usb/gadget/function/u_serial.c
> > @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
> > unsigned long flags;
> > int status;
> >
> > - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",
> > + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
> ^
> S ??

%ps is the non-function-pointer version of %pf. %pS is the
non-function-pointer version of %pF. I didn't change the capitalization
of any of these -- if that's warranted in some places, it's outside the
scope of this treewide patchset.

-Scott




\
 
 \ /
  Last update: 2015-03-12 07:01    [W:0.384 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site