lkml.org 
[lkml]   [2015]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] docproc: handle realloc() failure in find_all_symbols()
Date
check realloc rc and avoid potential null dereference
and memory leak

Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
---
scripts/docproc.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/scripts/docproc.c b/scripts/docproc.c
index e267e621..438fc91 100644
--- a/scripts/docproc.c
+++ b/scripts/docproc.c
@@ -396,6 +396,10 @@ static void find_all_symbols(char *filename)
4096)) > 0) {
data_len += ret;
data = realloc(data, data_len + 4096);
+ if (data == NULL) {
+ perror("realloc");
+ exit(1);
+ }
}
} while (ret == -EAGAIN);
if (ret != 0) {
@@ -420,6 +424,10 @@ static void find_all_symbols(char *filename)
start = all_list_len;
all_list_len += count;
all_list = realloc(all_list, sizeof(char *) * all_list_len);
+ if (all_list == NULL) {
+ perror("realloc");
+ exit(1);
+ }
str = data;
for (i = 0; i < data_len && start != all_list_len; i++) {
if (data[i] == '\0') {
--
1.8.1.msysgit.1


\
 
 \ /
  Last update: 2015-02-28 21:21    [W:0.043 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site