| From | Masahiro Yamada <> | Subject | [RESEND PATCH v2 16/16] clk: slightly optimize clk_core_set_parent() | Date | Mon, 28 Dec 2015 19:23:10 +0900 |
| |
If clk_fetch_parent_index() fails, p_rate is unused. Move the assignment after the error checking.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> ---
Changes in v2: None
drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 5b9aec0..e81301b 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1730,13 +1730,13 @@ static int clk_core_set_parent(struct clk_core *core, struct clk_core *parent) /* try finding the new parent index */ if (parent) { p_index = clk_fetch_parent_index(core, parent); - p_rate = parent->rate; if (p_index < 0) { pr_debug("%s: clk %s can not be parent of clk %s\n", __func__, parent->name, core->name); ret = p_index; goto out; } + p_rate = parent->rate; } /* propagate PRE_RATE_CHANGE notifications */ -- 1.9.1
|