Messages in this thread Patch in this message | | | From | Masahiro Yamada <> | Subject | [RESEND PATCH v2 04/16] clk: remove unnecessary !core->parents conditional | Date | Mon, 28 Dec 2015 19:22:58 +0900 |
| |
This if-block has been here since the introduction of the common clock framework. Now no clock drivers are statically initialized. core->parent is always NULL at this point. Drop the redundant check and the confusing comment.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> ---
Changes in v2: None
drivers/clk/clk.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 41179f3..30c0bbc 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2348,11 +2348,8 @@ static int __clk_core_init(struct clk_core *core) * in to clk_init during early boot; thus any access to core->parents[] * must always check for a NULL pointer and try to populate it if * necessary. - * - * If core->parents is not NULL we skip this entire block. This allows - * for clock drivers to statically initialize core->parents. */ - if (core->num_parents > 1 && !core->parents) { + if (core->num_parents > 1) { core->parents = kcalloc(core->num_parents, sizeof(struct clk *), GFP_KERNEL); /* -- 1.9.1
| |