Messages in this thread | | | Date | Thu, 24 Dec 2015 17:26:13 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH v2] um: Fix build error and kconfig for i386 |
| |
On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote: > > On 23/12/2015 22:42, Josh Triplett wrote: > > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote: > >> Fix build error by selecting COREDUMP when X86_32 is selected: > >> > >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > >> (.text+0x3e62): undefined reference to `dump_emit' > >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data': > >> (.text+0x3eef): undefined reference to `dump_emit' > >> > >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > >> Signed-off-by: Mickaël Salaün <mic@digikod.net> > >> Cc: Jeff Dike <jdike@addtoit.com> > >> Cc: Richard Weinberger <richard@nod.at> > >> Cc: Josh Triplett <josh@joshtriplett.org> > >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > >> Cc: Michal Marek <mmarek@suse.cz> > >> Cc: Andrew Morton <akpm@linux-foundation.org> > >> Cc: Linus Torvalds <torvalds@linux-foundation.org> > > > > I suppose um doesn't care deeply about binary size, but ideally I would > > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when > > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF. > > That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
-mm regularly replaces patches with newer versions, so that ought to be fine.
| |