Messages in this thread | | | Date | Wed, 23 Dec 2015 13:42:12 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH v2] um: Fix build error and kconfig for i386 |
| |
On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote: > Fix build error by selecting COREDUMP when X86_32 is selected: > > arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > (.text+0x3e62): undefined reference to `dump_emit' > arch/x86/um/built-in.o: In function `elf_core_write_extra_data': > (.text+0x3eef): undefined reference to `dump_emit' > > Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > Signed-off-by: Mickaël Salaün <mic@digikod.net> > Cc: Jeff Dike <jdike@addtoit.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Josh Triplett <josh@joshtriplett.org> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > Cc: Michal Marek <mmarek@suse.cz> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
I suppose um doesn't care deeply about binary size, but ideally I would suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
> arch/x86/um/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig > index ed56a1c4ae73..bb7cd8b38043 100644 > --- a/arch/x86/um/Kconfig > +++ b/arch/x86/um/Kconfig > @@ -26,6 +26,7 @@ config X86_32 > select CLONE_BACKWARDS > select OLD_SIGSUSPEND3 > select OLD_SIGACTION > + select COREDUMP > > config X86_64 > def_bool 64BIT > -- > 2.6.4 >
| |