lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: remove redundant conditions
Date
From: Felipe Balbi
> Sent: 10 December 2015 15:14
> "Geyslan G. Bem" <geyslan@gmail.com> writes:
>
> > This patch removes redundant conditions.
> >
> > - (!A || (A && B)) is the same as (!A || B).
> > - (length && length > 5) can be reduced to a single evaluation.
> >
> > Caught by: cppcheck
> >
> > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> > ---
>
> I guess you didn't get previous comment in time; let's split this per
> driver so different maintainers can pick their parts.

I also suspect that gcc will optimise out the redundant checks as well.

David



\
 
 \ /
  Last update: 2015-12-10 17:01    [W:0.074 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site