Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] usb: remove redundant conditions | Date | Thu, 10 Dec 2015 15:17:21 +0000 |
| |
From: Felipe Balbi > Sent: 10 December 2015 15:14 > "Geyslan G. Bem" <geyslan@gmail.com> writes: > > > This patch removes redundant conditions. > > > > - (!A || (A && B)) is the same as (!A || B). > > - (length && length > 5) can be reduced to a single evaluation. > > > > Caught by: cppcheck > > > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > > --- > > I guess you didn't get previous comment in time; let's split this per > driver so different maintainers can pick their parts.
I also suspect that gcc will optimise out the redundant checks as well.
David
| |