Messages in this thread | | | Date | Thu, 10 Dec 2015 11:44:30 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] usb: remove redundant conditions |
| |
On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote: > This patch removes redundant conditions. > > - (!A || (A && B)) is the same as (!A || B). > - (length && length > 5) can be reduced to a single evaluation. > > Caught by: cppcheck > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > drivers/usb/gadget/udc/s3c-hsudc.c | 2 +- > drivers/usb/host/fhci-sched.c | 2 +- > drivers/usb/musb/musb_gadget.c | 5 ++--- > drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++--------------------- > drivers/usb/serial/mos7840.c | 2 +- > 5 files changed, 19 insertions(+), 27 deletions(-)
Please split out (at least) the usb-serial changes into two patches.
Johan
| |