Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] regulator: core: Ensure we lock all regulators | Date | Tue, 01 Dec 2015 20:37:35 +0100 |
| |
On Tuesday 01 December 2015 16:53:01 Mark Brown wrote: > On Tue, Dec 01, 2015 at 05:45:17PM +0100, Arnd Bergmann wrote: > > On Tuesday 01 December 2015 16:40:57 Mark Brown wrote: > > > > mutex_lock(&rdev->mutex); > > > - for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++) > > > + for (i = 1; rdev; rdev = rdev->supply->rdev, i++) > > > mutex_lock_nested(&rdev->mutex, i); > > > I think now we have a double lock, the initial mutex_lock() needs to > > be removed again. > > Ugh, I even made that fix before I sent but didn't actually commit it >
I'm glad I'm not the only one who can screw up a trivial one-line fix to this damned function. ;-)
I'm still leading with three stupid mistakes over your one though.
Arnd
| |