lkml.org 
[lkml]   [2015]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] regulator: core: Ensure we lock all regulators
Date
On Tuesday 01 December 2015 16:40:57 Mark Brown wrote:
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index daffff83ced2..f71db02fcb71 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -141,7 +141,7 @@ static void regulator_lock_supply(struct regulator_dev *rdev)
> int i;
>
> mutex_lock(&rdev->mutex);
> - for (i = 1; rdev->supply; rdev = rdev->supply->rdev, i++)
> + for (i = 1; rdev; rdev = rdev->supply->rdev, i++)
> mutex_lock_nested(&rdev->mutex, i);
>

I think now we have a double lock, the initial mutex_lock() needs to
be removed again.

Arnd


\
 
 \ /
  Last update: 2015-12-01 18:01    [W:0.072 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site