Messages in this thread | | | Date | Tue, 1 Dec 2015 20:33:58 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2 3/3] tpm_tis: Clean up the force=1 module parameter |
| |
Hello,
On Tue, Dec 01, 2015 at 11:58:29AM -0700, Jason Gunthorpe wrote: > The TPM core has long assumed that every device has a driver attached, > however commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain > callbacks are called unconditionally") breaks that assumption.
you asked for an alternative wording here. What about:
The TPM core has long assumed that every device has a driver attached, which is not valid. This was noticed with commit b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are called unconditionally") which made probing of the tpm_tis device fail by mistake and resulted in an oops later on.
?
> Rework the TPM setup to create a platform device with resources and > then allow the driver core to naturally bind and probe it through the > normal mechanisms. All this structure is needed anyhow to enable TPM > for OF environments. > > Finally, since the entire flow is changing convert the init/exit to use > the modern ifdef-less coding style when possible > > Reported-by: "Wilck, Martin" <martin.wilck@ts.fujitsu.com> > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Best regards, Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |