lkml.org 
[lkml]   [2015]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter
    On Mi, 2015-12-02 at 12:11 -0700, Jason Gunthorpe wrote:

    > > What is the address tpm_tis should be using? I see two things, it
    > > either uses the x86 default address or it expects the ACPI to have a
    > > MEM resource. AFAIK ACPI should never rely on hard wired addresses, so
    > > I removed that code in this series. Perhaps tpm_tis should be using
    > > control_area_pa ? Will ACPI ever present a struct resource? (if yes,
    > > why isn't tpm_crb using one?)
    >
    > Is then still a problem. On Martin's system the MSFT0101 device does
    > not have a struct resource attached to it. Does any system, or is this
    > just dead code?

    ACPI defines a mem resource corresponding to the standard TIS memory
    area on my system, and it used to be detected fine with Jarkko's patch.
    Somehow your latest changes broke it, not sure why.

    Martin

    \
     
     \ /
      Last update: 2015-12-03 09:41    [W:9.307 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site