Messages in this thread | | | Date | Tue, 1 Dec 2015 09:19:05 -0800 | Subject | Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() | From | Linus Torvalds <> |
| |
On Tue, Dec 1, 2015 at 9:13 AM, Borislav Petkov <bp@alien8.de> wrote: > > Oh sure, I didn't mean you. I was simply questioning that whole > identify-resource-by-its-name approach. And that came with: > > 67cf13ceed89 ("x86: optimize resource lookups for ioremap") > > I just think it is silly and that we should be identifying resource > things in a more robust way.
I could easily imagine just adding a IORESOURCE_RAM flag (or SYSMEM or whatever). That sounds sane. I agree that comparing the string is ugly.
> Btw, the ->name thing in struct resource has been there since a *long* > time
It's pretty much always been there. It is indeed meant for things like /proc/iomem etc, and as a debug aid when printing conflicts, yadda yadda. Just showing the numbers is usually useless for figuring out exactly *what* something conflicts with.
Linus
| |