Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH v3 1/3] resource: Add @flags to region_intersects() | Date | Tue, 01 Dec 2015 12:02:26 -0500 |
| |
Dan Williams <dan.j.williams@intel.com> writes:
>>> @@ -57,7 +57,7 @@ static void *try_ram_remap(resource_size_t offset, size_t size) >>> */ >>> void *memremap(resource_size_t offset, size_t size, unsigned long flags) >>> { >>> - int is_ram = region_intersects(offset, size, "System RAM"); >> >> Ok, question: why do those resource things types gets identified with >> a string?! We have here "System RAM" and next patch adds "Persistent >> Memory". >> >> And "persistent memory" or "System RaM" won't work and this is just >> silly. >> >> Couldn't struct resource have gained some typedef flags instead which we >> can much easily test? Using the strings looks really yucky. >> > > At least in the case of region_intersects() I was just following > existing strcmp() convention from walk_system_ram_range.
...which is done in the page fault path. I agree with the suggestion to get strcmp out of that path.
-Jeff
| |