lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] fix compare_const_fl.cocci warnings
Move constants to the right of binary operators.

Semantic patch information:
Depends on personal taste in some cases.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Dave Penkler <dpenkler@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

This is what Coccinelle generates. But it would really be more normal in
the form !(x&y).

usbtmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -494,7 +494,7 @@ static int usbtmc488_ioctl_simple(struct

dev = &data->intf->dev;

- if (0 == (data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE))
+ if ((data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE) == 0)
return -EINVAL;

buffer = kmalloc(8, GFP_KERNEL);

\
 
 \ /
  Last update: 2015-11-11 14:41    [W:0.029 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site