Messages in this thread Patch in this message | | | Date | Wed, 11 Nov 2015 13:19:23 +0000 (GMT) | From | Julia Lawall <> | Subject | [PATCH] fix compare_const_fl.cocci warnings |
| |
Move constants to the right of binary operators.
Semantic patch information: Depends on personal taste in some cases.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Dave Penkler <dpenkler@gmail.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
This is what Coccinelle generates. But it would really be more normal in the form !(x&y).
usbtmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/class/usbtmc.c +++ b/drivers/usb/class/usbtmc.c @@ -494,7 +494,7 @@ static int usbtmc488_ioctl_simple(struct
dev = &data->intf->dev;
- if (0 == (data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE)) + if ((data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE) == 0) return -EINVAL;
buffer = kmalloc(8, GFP_KERNEL);
| |