lkml.org 
[lkml]   [2015]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls
On Tue, Nov 10, 2015 at 10:33:29AM -0500, Jeff Moyer wrote:
> Jerry Hoemann <jerry.hoemann@hpe.com> writes:
>
> > The NVDIMM code in the kernel supports an IOCTL interface to user
> > space based upon the Intel Example DSM:
> >
> > http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf
> >
> > This interface cannot be used by other NVDIMM DSMs that support
> > incompatible functions.
> >
> > This patch set adds a generic "passthru" IOCTL interface which
> > is not tied to a particular DSM.
> >
> > A new IOCTL type "P" is added for the pass thru call.
> >
> > The new data structure ndn_pkg serves as a wrapper for the passthru
> > calls. This wrapper supplies the data that the kernel needs to
> > make the _DSM call.
>
> What does 'ndn' stand for? If it stands for NVDIMM-N, then I think

Yes, hold over from earlier, less generic version.

> that's too narrow a scope. Anyway, it helps readability if you call out
> what abbreviations mean, especially when it's non-obvious.

Will fix in version 2.



>
> > Jerry Hoemann (4):
> > nvdimm: Add wrapper for IOCTL pass thru.
> > nvdimm: Add IOCTL pass thru
> > nvdimm: Add IOCTL pass thru
>
> You should really give each patch a different subject.


Will do.


>
> Cheers,
> Jeff

--

-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard Enterprise

3404 E Harmony Rd. MS 36 phone: (970) 898-1022
Ft. Collins, CO 80528 FAX: (970) 898-0707
email: jerry.hoemann@hpe.com
-----------------------------------------------------------------------------


\
 
 \ /
  Last update: 2015-11-10 23:01    [W:0.176 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site