Messages in this thread | | | Date | Tue, 10 Nov 2015 18:42:38 -0700 | From | Jerry Hoemann <> | Subject | Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru |
| |
On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote: > Jerry Hoemann <jerry.hoemann@hpe.com> writes: > > > + uuid = pkg->h.dsm_uuid; > > + rev = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1; > > Shouldn't revision id be required? >
Yes it should be. Good catch.
I was testing use of reclaiming previously unused members of the structure. I should have removed this line.
And this reminds me that I should also add a test that the reserved fields of ndn_pkg are actually zero.
I'll address both in version 2.
thanks
--
----------------------------------------------------------------------------- Jerry Hoemann Software Engineer Hewlett-Packard Enterprise -----------------------------------------------------------------------------
| |