lkml.org 
[lkml]   [2015]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] nvdimm: Add IOCTL pass thru
On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote:
> Jerry Hoemann <jerry.hoemann@hpe.com> writes:
>
> > + uuid = pkg->h.dsm_uuid;
> > + rev = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1;
>
> Shouldn't revision id be required?
>

Yes it should be. Good catch.

I was testing use of reclaiming previously unused members of
the structure. I should have removed this line.

And this reminds me that I should also add a test that the reserved fields
of ndn_pkg are actually zero.

I'll address both in version 2.

thanks

--

-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard Enterprise
-----------------------------------------------------------------------------


\
 
 \ /
  Last update: 2015-11-11 03:01    [W:0.649 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site