Messages in this thread Patch in this message | | | From | Giel van Schijndel <> | Subject | [PATCH] Fix error-code overwrite bug | Date | Sun, 4 Jan 2015 19:04:22 +0100 |
| |
Don't overwrite the returned error code with the boolean test used by the if-statement (otherwise it'd be 1 or 0 always, 1 in the if-block). --- drivers/mtd/nftlmount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c index 51b9d6a..1cbeb6b 100644 --- a/drivers/mtd/nftlmount.c +++ b/drivers/mtd/nftlmount.c @@ -91,7 +91,7 @@ static int find_boot_record(struct NFTLrecord *nftl) /* To be safer with BIOS, also use erase mark as discriminant */ if ((ret = nftl_read_oob(mtd, block * nftl->EraseSize + SECTORSIZE + 8, 8, &retlen, - (char *)&h1) < 0)) { + (char *)&h1)) < 0) { printk(KERN_WARNING "ANAND header found at 0x%x in mtd%d, but OOB data read failed (err %d)\n", block * nftl->EraseSize, nftl->mbd.mtd->index, ret); continue; -- 2.1.4
| |