lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used
On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> > Richard, asked some questions out of band.
> >
> > I like these patches where they can remove the whole line. I don't like
> > them where they leave stray, unneeded function calls. Or if we know
> > that we need the function calls then I like those.
> >
> > Also when it comes to the point where we move this code out of staging
> > then we can look at these warnings again. Normally people are good at
> > fixing up any remaining static checker warnings at the end. (Except for
> > binder, obviously. Binder didn't clean up anything. It's maintained by
> > a mailing list which has yet to add itself to MAINTAINERS. Stupid
> > binder mailing list).
>
> What remaining issues were in the binder code? And I have a
> non-mailing-list MAINTAINERS entry for binder in linux-next, it will go
> to Linus in a few hours.
>

Oh. Hm... I looked at it again and it's not as bad as I remember. I
appologize. I did have a question but I'll take it to another thread.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-01-30 22:21    [W:0.048 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site