lkml.org 
[lkml]   [2015]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci1500: Change variables that is never used
Richard, asked some questions out of band.

I like these patches where they can remove the whole line. I don't like
them where they leave stray, unneeded function calls. Or if we know
that we need the function calls then I like those.

Also when it comes to the point where we move this code out of staging
then we can look at these warnings again. Normally people are good at
fixing up any remaining static checker warnings at the end. (Except for
binder, obviously. Binder didn't clean up anything. It's maintained by
a mailing list which has yet to add itself to MAINTAINERS. Stupid
binder mailing list).

regards,
dan carpenter


\
 
 \ /
  Last update: 2015-01-30 21:41    [W:0.097 / U:27.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site