Messages in this thread | | | Date | Mon, 26 Jan 2015 10:47:24 +0900 | From | Jaehoon Chung <> | Subject | Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420 |
| |
Hi,
On 01/24/2015 12:59 AM, Javier Martinez Canillas wrote: > Hello Sjoerd, > > On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons > <sjoerd.simons@collabora.co.uk> wrote: >>> >>> If this pin is used by the Odroid XU3 board, shouldn't be defined in >>> the exynos5422-odroidxu3.dts instead? >> >> It's not just used by the XU3 though, it's also hooked up on the peach >> pi chromebook for example and i would expect it to be hooked up on most >> board with an eMMC >> >> This change is consistent with most of the special purpose GPIO pins >> defined in that file, so i don't see the problem with including it in >> that pinctrl file > > In that case I completely agree that it should be defined in the .dtsi > but that is not what the commit message said though :-)
I will resend the patch with obvious commit message. Thanks for review.
Best Regards, Jaehoon Chung
> > Best regards, > Javier >
| |