lkml.org 
[lkml]   [2015]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420
From
Date
On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote:
> Hello Jaehoon,
>
> On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> > Add sd0_rst node to exynos5420-pinctrl.dtsi.
> > (It's used on odroid-xu3 board)
> >
>
> It would be good to mention which device needs this pinctrl line.
>
> > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 5 +++++
>
> If this pin is used by the Odroid XU3 board, shouldn't be defined in
> the exynos5422-odroidxu3.dts instead?

It's not just used by the XU3 though, it's also hooked up on the peach
pi chromebook for example and i would expect it to be hooked up on most
board with an eMMC

This change is consistent with most of the special purpose GPIO pins
defined in that file, so i don't see the problem with including it in
that pinctrl file
--
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
[unhandled content-type:application/x-pkcs7-signature]
\
 
 \ /
  Last update: 2015-01-23 17:01    [W:0.828 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site