lkml.org 
[lkml]   [2015]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test'
On Fri, 23 Jan 2015, Johannes Weiner wrote:

> struct mem_cgroup_tree_per_node *rtpn;
> struct mem_cgroup_tree_per_zone *rtpz;
> - int tmp, node, zone;
> + int node, zone;
>
> for_each_node(node) {

Do for_each_online_node(node) {

instead?

> - tmp = node;
> - if (!node_state(node, N_NORMAL_MEMORY))
> - tmp = -1;
> - rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, tmp);
> + rtpn = kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node);
> BUG_ON(!rtpn);
>
> soft_limit_tree.rb_tree_per_node[node] = rtpn;
>
> --
>
> Is the assumption of this patch wrong? Does the specified node have
> to be online for the fallback to work?
>
> Thanks
>


\
 
 \ /
  Last update: 2015-01-23 21:41    [W:0.139 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site