Messages in this thread | | | Date | Fri, 23 Jan 2015 11:02:04 -0500 | From | Johannes Weiner <> | Subject | Re: mmotm 2015-01-22-15-04: qemu failure due to 'mm: memcontrol: remove unnecessary soft limit tree node test' |
| |
On Fri, Jan 23, 2015 at 09:17:44AM -0600, Christoph Lameter wrote: > On Fri, 23 Jan 2015, Johannes Weiner wrote: > > > Is the assumption of this patch wrong? Does the specified node have > > to be online for the fallback to work? > > Nodes that are offline have no control structures allocated and thus > allocations will likely segfault when the address of the controls > structure for the node is accessed. > > If we wanted to prevent that then every allocation would have to add a > check to see if the nodes are online which would impact performance.
Okay, that makes sense, thank you.
Andrew, can you please drop this patch?
| |