Messages in this thread | | | Date | Mon, 29 Sep 2014 22:17:29 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH 2/4] ARM: DT: apq8064: Add usb host support. |
| |
On Mon 29 Sep 02:15 PDT 2014, Srinivas Kandagatla wrote:
> This patch adds device tree nodes to support two usb hosts on APQ8064 > SOC. >
Sorry for not looking at the entire series before answering patch 1. I still think you should add all the regulators in the first patch anyways.
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -263,6 +263,91 @@ > #address-cells = <1>; > #size-cells = <0>; > > + pm8921_s3: pm8921-s3 { > + compatible = "qcom,rpm-pm8921-smps"; > + reg = <QCOM_RPM_PM8921_SMPS3>; > + > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + qcom,boot-load = <49360>;
As it was unclear how to handle load in the driver I dropped boot-load for now. Please leave it out until someone have added it to the driver.
> + qcom,switch-mode-frequency = <3200000>; > + regulator-always-on; > + }; > + > + pm8921_l3: pm8921-l3 { > + compatible = "qcom,rpm-pm8921-pldo"; > + reg = <QCOM_RPM_PM8921_LDO3>; > + > + regulator-min-microvolt = <3050000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + qcom,boot-load = <50000>;
Dito
> + }; > + > + pm8921_l23: pm8921-l23 { > + compatible = "qcom,rpm-pm8921-pldo"; > + reg = <QCOM_RPM_PM8921_LDO23>; > + > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1800000>; > + qcom,boot-load = <50000>;
Dito
> + regulator-always-on;
Why are all these "always-on"?
> + }; > + > + }; > + > > /* Temporary fixed regulator */ > -- > 1.9.1 >
| |