lkml.org 
[lkml]   [2014]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/4] ARM: DT: apq8064: Add SATA controller support.
    On 09/29/14 02:15, Srinivas Kandagatla wrote:
    > @@ -396,6 +407,35 @@
    > usb-phy = <&usb4_phy>;
    > };
    >
    > + sata_phy0:sata-phy@1b400000{

    add some spaces here?

    > + compatible = "qcom,apq8064-sata-phy";
    > + reg = <0x1b400000 0x200>;
    > + reg-names = "phy_mem";
    > + clocks = <&gcc SATA_PHY_CFG_CLK>;
    > + clock-names = "cfg";
    > + #phy-cells = <0>;

    These two lost the pretty tabs.

    > + };
    > +
    > + sata0: sata@29000000 {
    > + compatible = "generic-ahci";
    > + reg = <0x29000000 0x180>;
    > + interrupts = <0 209 0>;

    Sorry I'm nitpicking but it annoys me. Either align it all or don't
    align it.

    > + clocks = <&gcc SFAB_SATA_S_H_CLK>, <&gcc SATA_H_CLK>,
    > + <&gcc SATA_A_CLK>, <&gcc SATA_RXOOB_CLK>,
    > + <&gcc SATA_PMALIVE_CLK>;
    > +
    > + clock-names = "slave_iface", "iface",
    > + "bus", "rxoob",
    > + "core_pmalive";
    > + assigned-clocks = <&gcc SATA_RXOOB_CLK>,
    > + <&gcc SATA_PMALIVE_CLK>;
    > + assigned-clock-rates = <100000000>, <100000000>;
    > +
    > + phys = <&sata_phy0>;
    > + phy-names = "sata-phy";
    > + target-supply = <&pm8921_s4>;
    > + };
    > +
    > /* Temporary fixed regulator */
    > vsdcc_fixed: vsdcc-regulator {
    > compatible = "regulator-fixed";


    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    hosted by The Linux Foundation



    \
     
     \ /
      Last update: 2014-09-30 00:41    [W:2.792 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site