| Date | Wed, 24 Sep 2014 10:59:21 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v1 10/12] tpm: TPM 2.0 FIFO Interface |
| |
On Wed, Sep 24, 2014 at 12:06:00PM +0300, Jarkko Sakkinen wrote:
> - if (!(chip = tpm_register_hardware(dev, &tpm_tis))) > + chip = tpm_chip_alloc(dev, &tpm_tis); > + if (!chip) > return -ENODEV;
Please put this in a separate patch, don't co-mingle it with TPM2 support. If drivers are going to be converted, then I want to see the new API used properly and the driver itself to be a *correct* example of using the new API.
So you have to purge the tis_chips, fix the missing removal functions, call unregister, fix the force probe path, etc.
> chip->vendor.iobase = ioremap(start, len);
Since this changes the ordering, can we devm this ioremap?
Jason
|